Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BB-9101] Alternative fix for default filter #66

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

pkulkark
Copy link
Member

This PR replaces the solution provided in #65.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (acbd7fa) to head (e3f7bef).
Report is 5 commits behind head on asu-moe/redwood-css.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #66      +/-   ##
=======================================================
+ Coverage                92.54%   92.60%   +0.06%     
=======================================================
  Files                      706      706              
  Lines                    12515    12524       +9     
  Branches                  2728     2742      +14     
=======================================================
+ Hits                     11582    11598      +16     
+ Misses                     898      891       -7     
  Partials                    35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cup0fCoffee
Copy link
Member

👍 Once the quality check failure is addressed.

  • I tested this: Went to studio home page, and verified that only active courses are displayed by default.
  • I read through the code
  • [-] I checked for accessibility issues
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@pkulkark pkulkark force-pushed the pooja/bb9101-alternative-fix branch 3 times, most recently from 4799d74 to 1bf6ecd Compare September 13, 2024 15:37
@pkulkark pkulkark force-pushed the pooja/bb9101-alternative-fix branch from 1bf6ecd to e3f7bef Compare September 13, 2024 15:57
@pkulkark pkulkark merged commit 594bf8d into asu-moe/redwood-css Sep 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants